Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NXF_HOME env var for nextflow home directory, if set #800

Merged
merged 2 commits into from
Nov 27, 2020

Conversation

ewels
Copy link
Member

@ewels ewels commented Nov 26, 2020

Look for and use $NXF_HOME for stuff if set, before defaulting to ~/.nextflow

Closes #798

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels added the command line tools Anything to do with the cli interfaces label Nov 26, 2020
@codecov

This comment has been minimized.

@ewels ewels requested review from KevinMenden and a team November 26, 2020 21:18
Copy link
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Couldn't find any other uses of NXF_HOME or NXF_ASSETS in the codebase. Except in test_list.py, but those are fine.
As far as I can tell, all the other Nextflow environment variables don't matter for this purpose.
Should be fine :)

@ewels ewels merged commit a47c2f5 into nf-core:dev Nov 27, 2020
@ewels ewels deleted the list-nxfhome branch December 2, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command line tools Anything to do with the cli interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants