Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra lint test with --release #968

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 25, 2021

  • Run an extra job in the CI to do linting with --release to try to pick up any other nasty hidden errors like the one that sneaked into the recent releases.
  • Tweak the traceback setup so that they are not so long and people can paste them into Slack 😉

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #968 (2ecae0c) into dev (62e2529) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #968   +/-   ##
=======================================
  Coverage   69.30%   69.30%           
=======================================
  Files          34       34           
  Lines        4225     4225           
=======================================
  Hits         2928     2928           
  Misses       1297     1297           
Impacted Files Coverage Δ
nf_core/__main__.py 61.26% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e2529...2ecae0c. Read the comment docs.

Copy link
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@KevinMenden KevinMenden merged commit e7fd780 into nf-core:dev Mar 25, 2021
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ewels ewels deleted the extra-ci-test branch March 25, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants