Restore partial functionality of button Validate / Restore Ontology Term #517
Conversation
Delete propertie column values when main / unit column ins empty
Etschbeijer
requested review from
Freymaurer,
HLWeil and
kMutagene
and removed request for
Freymaurer
|
It is only a partial fix, the second half of the functionality of the button will be fixed in this Issue: #522 |
|
|
||
| return messages | ||
| } | ||
| ) | ||
|
|
||
| let fillEmptyBuildingBlocks () = |
There was a problem hiding this comment.
rename to autoCompleteFromExistingTerms, add extensive comment in xml style to explain functionality.
| //When msg > 0 there is an error and we can skip the filling of the rows because the columns are not valid | ||
| if messages.Length > 0 then return messages | ||
| else | ||
| let! excelTable = getActiveAnnotationTable context |
There was a problem hiding this comment.
Must parse table a second time after validateAnnotationTable. Maybe have validateAnnotationTable have return the table if validated successful. This would require a new ouput using Result
let tryString (x: string) =
if x.StartsWith "y" then
Result.Ok true
else
Result.Error false
match tryString "yes" with
| Result.Ok x -> printfn "Ok: %A" x
| Result.Error x -> printfn "Error: %A" xThere was a problem hiding this comment.
use match case instead of if-else on line 1971
| //Arctable enables a fast check for term and unit building blocks | ||
| let! arcTable = ArcTable.tryGetFromExcelTable(excelTable, context) | ||
|
|
||
| let arcTable = |
| @@ -55,7 +55,7 @@ let private shortCutIconList model dispatch = | |||
| Html.i [prop.className "fa-solid fa-pen"] | |||
| ], | |||
| (fun _ -> | |||
| SpreadsheetInterface.ValidateAnnotationTable |> InterfaceMsg |> dispatch | |||
| //SpreadsheetInterface.ValidateAnnotationTable |> InterfaceMsg |> dispatch | |||
| SpreadsheetInterface.UpdateTermColumns |> InterfaceMsg |> dispatch | |||
There was a problem hiding this comment.
Maybe coin a term for this process. Because we verify the table, we clean it up with leftover terms and try to fill TSR TAN from term name (in the future). We might need a word for this, that we both start using for this process.
Closes #511