feat: create cron nft-ttr to measure nft time to retrievability #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobengo
changed the title
gobengo
changed the title
gobengo
force-pushed
the
issues/1943-measure-ttr
branch
from
93cd4e4
to
45e8abf
Compare
Codecov Report
@@ Coverage Diff @@
## main #1945 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 1259 1259
=========================================
Hits 1259 1259 Continue to review full report at Codecov.
|
gobengo
force-pushed
the
issues/1943-measure-ttr
branch
from
0b392a9
to
e6cfff9
Compare
gobengo
force-pushed
the
issues/1943-measure-ttr
branch
from
cbdd896
to
b986dab
Compare
gobengo
commented
May 31, 2022
Adds an example showing how to store ERC-721 compatible metadata with image data retrieved from a URL on the internet. Adapted from https://github.com/nftstorage/nft.storage/blob/main/examples/client/browser/store.html
This reverts commit 726a7a4.
|
@alanshaw Should I merge this diff that edits unrelated modules to pass new lint rules into this PR? Or do as followup to this one? I'd slightly prefer the latter. |
alanshaw
approved these changes
Jun 16, 2022
| "@types/mocha", | ||
| "@types/node", | ||
| "@types/webpack-env" | ||
| ] |
There was a problem hiding this comment.
Why this nohoist change? Unless it causing an issue, can we move to a separate PR?
There was a problem hiding this comment.
It was causing an issue I believe. I will verify it's really required now.
There was a problem hiding this comment.
it wasn't required. :/ ty
| export function createRetrievalDurationSecondsMetric(registry) { | ||
| /** @type RetrievalDurationSecondsMetric} */ | ||
| const metric = new Histogram({ | ||
| name: 'retrieval_duration_seconds', |
This was referenced Jun 16, 2022
gobengo
added a commit
that referenced
this pull request
Jun 22, 2022
* fix nft-ttr logging and multiple gateways support * remove byteLength label from RetrievalDurationMetric * yarn * yarn * cron.yml action does npm rebuild sharp before test * Revert "cron.yml action does npm rebuild sharp before test" This reverts commit 3d00e0d. * cron ava disble workerThreads because sharp doesn't play nice with them https://sharp.pixelplumbing.com/install#worker-threads * cron workflow runs on pull_request to all branches, not just main * cron: add linearBuckets to retrieval_duration_seconds histogram * measureNftTimeToRetrievability.js starts retrievals in parallel after store so both start right after upload. previous serial method would lead to too-low metrics for the second gateway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Plan
"sade": "^1.7.4"Possible Futures
.eslintConfig.overrides