-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: followup #1945 after testing nft-ttr cron #2000
Conversation
Deploying with Cloudflare Pages
|
Codecov Report
@@ Coverage Diff @@
## main #2000 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 1259 1259
=========================================
Hits 1259 1259 Continue to review full report at Codecov.
|
This reverts commit 3d00e0d.
… store so both start right after upload. previous serial method would lead to too-low metrics for the second gateway
help: 'How long, in seconds, it took to retrieve an nft image after uploading', | ||
registers: [registry], | ||
labelNames: ['byteLength'], | ||
labelNames: [], | ||
buckets: linearBuckets(0, 0.5, 20), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these buckets should help give some granular measurement to the panels i set up here: #2003
Motivation:
--gateway {gatewayUrl}
flags (space-delimited values used to work with yargs, but not so easy with sade, so for now lets just do one-value-per-flag)byteLength
label from the prometheus histogram. I'm not sure that it really adds value as it was (e.g. without bucketing). For now I just want to get something useful showing in grafana without as little extra fields as possible, so dont need byteLength.