Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate repo owner and fix smoke test requirement #5791

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Remove duplicate repo owner and fix smoke test requirement #5791

merged 3 commits into from
Jun 19, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jun 19, 2024 •
edited
Loading

Proposed changes

The repository url in the release workflow was being rendered as nginxinc/nginxinc/kubernetes-ingress, therefore having duplicate repo owners.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner June 19, 2024 13:45
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jun 19, 2024
@oseoin oseoin changed the title remove duplicate repo owner Remove duplicate repo owner and fix smoke test requirement Jun 19, 2024
@oseoin oseoin enabled auto-merge (squash) June 19, 2024 13:55
@oseoin oseoin merged commit 5b50945 into main Jun 19, 2024
78 checks passed
@oseoin oseoin deleted the fix-gh-repo-owner branch June 19, 2024 14:43
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
@pdabelf5 @ssrahul96
Remove duplicate repo owner and fix smoke test requirement (nginxinc#…
8a16ea1 
…5791)
This was referenced Jul 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@vepatel vepatel vepatel approved these changes

@oseoin oseoin oseoin approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pdabelf5 @oseoin @vepatel @AlexFenlon @jjngx