Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate repo owner and fix smoke test requirement #5791

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Remove duplicate repo owner and fix smoke test requirement #5791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6be7f0b
remove duplicate repo owner
pdabelf5 Jun 19, 2024
d7d6152
fix smoke test requirements
oseoin Jun 19, 2024
0c77ab8
Merge branch 'main' into fix-gh-repo-owner
oseoin Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,13 +754,15 @@ jobs:
if: ${{ always() }}
runs-on: ubuntu-22.04
name: Final CI Results
needs: [tag-stable]
needs: [tag-stable, smoke-tests]
steps:
- run: |
result="${{ needs.tag-stable.result }}"
if [[ $result == "success" || $result == "skipped" ]]; then
exit 0
else
tagResult="${{ needs.tag-stable.result }}"
smokeResult="${{ needs.smoke-tests.result }}"
if [[ $tagResult != "success" && $tagResult != "skipped" ]]; then
exit 1
fi
if [[ $smokeResult != "success" && $smokeResult != "skipped" ]]; then
exit 1
fi

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,12 +413,12 @@ jobs:
run: |
milestone_number=$(gh api \
-H "Accept: application/vnd.github.v3+json" \
/repos/${{ github.repository_owner }}/${{ github.repository }}/milestones \
/repos/${{ github.repository }}/milestones \
| jq --arg version ${{ inputs.nic_version }} -r \
'.[] | select(.title == $version) | .number')
if ! ${{ inputs.dry_run }}
gh api --method PATCH -H "Accept: application/vnd.github.v3+json" \
/repos/${{ github.repository_owner }}/${{ github.repository }}/milestones/${milestone_number} \
/repos/${{ github.repository }}/milestones/${milestone_number} \
else
echo "Skipping closing Github Release milestone, DRY_RUN"
fi
Expand All @@ -431,7 +431,7 @@ jobs:
release_id=$(gh api \
-H "Accept: application/vnd.github.v3+json" \
-H "X-GitHub-Api-Version: 2022-11-28" \
/repos/${{ github.repository_owner }}/${{ github.repository }}/releases \
/repos/${{ github.repository }}/releases \
| jq --arg version ${{ inputs.nic_version }} -r \
'.[] | select(.name == $version) | .id')
echo "release_id=${release_id}" >> $GITHUB_OUTPUT
Expand Down
Loading