-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add deploymentID to telemetry object collector #1597
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salonichf5
force-pushed
the
deploymentID
branch
from
February 20, 2024 17:28
8fb962f
to
9a769a9
Compare
kate-osborn
requested changes
Feb 20, 2024
pleshakov
suggested changes
Feb 20, 2024
kate-osborn
requested changes
Feb 20, 2024
github-actions
bot
added
documentation
Improvements or additions to documentation
and removed
enhancement
New feature or request
labels
Feb 21, 2024
Co-authored-by: Kate Osborn <50597707+kate-osborn@users.noreply.github.com>
* Add image source * Move env var to join the others
salonichf5
force-pushed
the
deploymentID
branch
from
February 21, 2024 19:00
46ab490
to
171b636
Compare
github-actions
bot
removed
documentation
Improvements or additions to documentation
helm-chart
Relates to helm chart
labels
Feb 21, 2024
pleshakov
reviewed
Feb 21, 2024
kate-osborn
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Michael Pleshakov <pleshakov@users.noreply.github.com>
pleshakov
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 (the failing unit test needs to be fixed though :) )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: As a user, I want to collect deployment identifier from NGF installations to correlate telemetry data with every unique installation of NGF.
Solution: Add a field
deploymentID
to telemetry object collector which reflects the UID of the replicaSet owner reference.Testing: Added & updated unit tests as needed. Manually tested on active NGF installations, logs below:
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #1304
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.