-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests/run conformance tests #713
Conversation
in-progress, seems like there's an issue with provisioner. @pleshakov is taking a look to confirm. |
when creating a deployment, the generated labels are too long -- I will prepare a fix |
Added a different bug -- #714 -- which is also a blocker This one prevented one of base Gateways to become Programmed in the status, because NGINX will fail to reload. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @vepatel
I found a few issues. but looks good otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Ability to run gateway api conformance tests locally on KinD cluster.
Solution: Run tests in a container with the help of provided make commands.
Testing: Build the test runner image and execute tests
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #648
Checklist
Before creating a PR, run through this checklist and mark each as complete.