Ensure uniqueness and validity of generated names and labels #716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Provisioner could generate an invalid name or a label for NKG static mode deployment. As a result, the provisioner would fail with an error like below:
Solution:
Provisioner will use the following format for names and labels of Deployments:
nginx-gateway-<number>
, where the number if an interger >= 1. For every new Gateway resource, the provisioner will increment the number by one.This approach will break if the provisioner is restarted, but we don't support provisioner for production yet, so it is acceptable.
Note: correlation between a Gateway resource and the corresponding Deployment can be found in the provisioner log. For example:
This PR will unblock #713 (comment)
Checklist
Before creating a PR, run through this checklist and mark each as complete.