-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SupportedKinds in ListenerStatus #809
Merged
ciarams87
merged 4 commits into
nginxinc:main
from
ciarams87:feat/gateway-status-supported-kinds
Jul 11, 2023
Merged
Support SupportedKinds in ListenerStatus #809
ciarams87
merged 4 commits into
nginxinc:main
from
ciarams87:feat/gateway-status-supported-kinds
Jul 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Jul 4, 2023
sjberman
approved these changes
Jul 5, 2023
kate-osborn
requested changes
Jul 5, 2023
kate-osborn
reviewed
Jul 5, 2023
ciarams87
force-pushed
the
feat/gateway-status-supported-kinds
branch
from
July 6, 2023 10:51
39561da
to
d4effcd
Compare
ciarams87
force-pushed
the
feat/gateway-status-supported-kinds
branch
from
July 7, 2023 11:00
ace7c3e
to
49ad5ee
Compare
kate-osborn
requested changes
Jul 7, 2023
ciarams87
force-pushed
the
feat/gateway-status-supported-kinds
branch
from
July 10, 2023 08:56
49ad5ee
to
78fa031
Compare
6 tasks
kate-osborn
approved these changes
Jul 10, 2023
ciarams87
force-pushed
the
feat/gateway-status-supported-kinds
branch
from
July 11, 2023 08:53
78fa031
to
e6d57f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently, we don't support setting SupportedKinds in ListenerStatus based on the spec.
SupportedKinds is the list indicating the Kinds supported by this listener. This MUST represent the kinds an implementation supports for that Listener configuration.
If kinds are specified in Spec that are not supported, they MUST NOT appear in this list and an implementation MUST set the “ResolvedRefs” condition to “False” with the “InvalidRouteKinds” reason. If both valid and invalid Route kinds are specified, the implementation MUST reference the valid Route kinds that have been specified.
Solution: Support setting SupportedKinds in ListenerStatus based on the spec.
Testing: Unit-tests have been updated and are passing, manual testing, and confirmed related conformance tests are now passing.
Closes #690
Checklist
Before creating a PR, run through this checklist and mark each as complete.