Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set correct nginx_up query and instance variable expression #62

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Set correct nginx_up query and instance variable expression #62

merged 1 commit into from
Aug 15, 2019

Conversation

edgarasg
Copy link
Contributor

@edgarasg edgarasg commented Aug 13, 2019 •
edited
Loading

Proposed changes

This corrects nginx_up panel to show value and instance variable to filter just nginx_exporter related metrics.

Checklist

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch on my own fork

@edgarasg
Set correct nginx_up query and instance variable expression
0cb4ec6 
Signed-off-by: EdgarasG <edgaras.giedre@hostinger.com>
@Dean-Coakley Dean-Coakley added the bug An issue reporting a potential bug label Aug 14, 2019
Rulox
Rulox suggested changes Aug 15, 2019
View reviewed changes
Copy link

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edgarasg

Thanks for the PR. It was, indeed, a bug 👍.

I just wanted to clarify one thing before approve+merge so if you can have a look at my comment and let me know your thoughts that would be great.

Thanks!

grafana/dashboard.json Show resolved Hide resolved
@Rulox Rulox mentioned this pull request Aug 15, 2019
Closed
@Rulox Rulox merged commit 29ec94b into nginxinc:master Aug 15, 2019
@edgarasg edgarasg deleted the fix/set_correct_nginx_up_expr branch August 15, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rulox Rulox Rulox approved these changes

Assignees
No one assigned
Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edgarasg @Rulox @Dean-Coakley