Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx: Fix nginx_up in grafana dashbpord #63

Closed
wants to merge 1 commit into from
Closed

nginx: Fix nginx_up in grafana dashbpord #63

wants to merge 1 commit into from

Conversation

paladox
Copy link

@paladox paladox commented Aug 14, 2019

The nginx_up{instance...} syntax requires ~ so that it's like:

nginx_up{instance=~"$instance"}

@paladox
nginx: Fix nginx_up in grafana dashbpord
45f18f5 
The nginx_up{instance...} syntax requires ~ so that it's like:

nginx_up{instance=~"$instance"}
@Dean-Coakley Dean-Coakley added the bug An issue reporting a potential bug label Aug 14, 2019
@Rulox
Copy link

Rulox commented Aug 15, 2019

Hi @paladox

Thanks for the PR, this is a bug yes. However, there is another PR that addresses this and was created before #62

We'll use that one as it was there before, it'll be merged shortly. Closing this as duplicated, but thanks again!

@Rulox Rulox closed this Aug 15, 2019
@Rulox Rulox removed their request for review August 15, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paladox @Rulox @Dean-Coakley