-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add app protocol #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking over this, I'm less sure about the enum approach. We might want to make it a string all the way through and defer validation to our hosted services. That way we can add new protocols we support there and don't have to go and update the sdk for each one. If we took that approach, the only thing I'd do in the builder methods would be to .to_lowercase()
it.
Ultimately up to product though. @salilsub thoughts?
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
I think as a general rule we should push more validation to our hosted services so we can adjust those rules over time. There will be exceptions, but I think @jrobsonchase is right on this one. |
a330b46
to
49d6e36
Compare
Why
We'd like to be able specify http2 when building an http tunnel
How
Add
app_protocol
to the builder and plumb theforwards_proto
into the session rpc.Validation
Run an example with the http2 app protocol and confirm the correct
forwardsProto
was set to"http2"
or""
.