ngrok: set the alpn field when app_protocol is specified #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Merged
OfTheDelmer
reviewed
Dec 15, 2023
jrobsonchase
force-pushed
the
josh/app_protocol_alpn
branch
from
52caed0 to
06c845a
Compare
OfTheDelmer
approved these changes
Jan 16, 2024
jrobsonchase
force-pushed
the
josh/app_protocol_alpn
branch
from
1e8498c to
f987c41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the upstream is a normal HTTPs server, it expects to have http/2 negotiated
via alpn. If alpn isn't provided, it will assume http/1.1. If our edge proxy is
sending down http/2 because
app_protocolwas specified, this results in aprotocol mismatch, and invalid requests/responses will be seen.
This ensures that the negotiation happens as expected.