Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move MockStore tests to a separate file #1873

Closed
timdeschryver opened this issue May 17, 2019 · 5 comments
Closed

Move MockStore tests to a separate file #1873

timdeschryver opened this issue May 17, 2019 · 5 comments
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Project: Store

Comments

@timdeschryver
Copy link
Member

Currently the MockStore tests are added to the Store tests, this makes them harder to find. That's why we want to extract the MockStore tests at https://github.com/ngrx/platform/blob/master/modules/store/spec/store.spec.ts#L450 to their own file.
@timdeschryver timdeschryver added Project: Store Accepting PRs community watch Someone from the community is working this issue/PR labels May 17, 2019
@timdeschryver
Copy link
Member Author

This one is picked up by @deli6z.

@alex-okrushko
Copy link
Member

alex-okrushko commented May 21, 2019 •
edited
Loading

I didn't realize this issue was opened - I moved the tests as part of #1878

@evgenyfedorenko
Copy link
Contributor

@alex-okrushko stole my chance to shine.

brandonroberts pushed a commit that referenced this issue May 21, 2019
@alex-okrushko @brandonroberts
fix(store): adjust mock store to handle selectors with props (#1878)
a7ded00 
Closes #1864, #1873
@brandonroberts
Copy link
Member

Fixed via #1878

@alex-okrushko
Copy link
Member

@alex-okrushko stole my chance to shine.

@deli6z there's plenty more! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Project: Store
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brandonroberts @alex-okrushko @evgenyfedorenko @timdeschryver