remove ionic overlay workaround and make login controller cleaner #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
darn... just looked at the changes... I meant to apply that declarative unsubscribe thing on the observable so a real request will be aborted if the user navigates away but I forgot :-/. |
|
request abort added to PR |
sinedied
reviewed
Jan 10, 2019
generators/app/templates/src/app/login/__auth._login.component.ts
Outdated
Show resolved
Hide resolved
sinedied
approved these changes
Jan 14, 2019
There was a problem hiding this comment.
Looks good!
Following your e2e changes, it might be interesting to migrate all promise code from service/components to async await 😃 (I know @captaincaius your initial Ionic PR had it, it might be time to resurrect this and complete the remaining work everywhere else).
But let's keep this in a separate PR, I've created #429 to follow
|
haha you were right though... it was sneaky of me to creep it into that PR :P my bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good news - ionic's overlays seem to be test-friendly now!
got rid of the mix of promises and rxjs in login controller. But after making it as clean and readable as Luiza suggested, I sacrificed a little readability to ensure that the API request goes in parallel to the loading overlay, uh, loading :P. Please let me know if you folks would prefer to prioritize readability instead.
please notice I snuck in a little memory leak fix into this commit by navigating based on the route snapshot instead of subscribing. Hope that's ok.