Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix encoding issue introduced in gulp v5.0 #1010

Closed
wants to merge 1 commit into from
Closed

fix encoding issue introduced in gulp v5.0 #1010

wants to merge 1 commit into from

Conversation

chrimesdev
Copy link
Member

@chrimesdev chrimesdev commented Sep 9, 2024 •
edited
Loading

Description

Fix encoding issue introduced in Gulp v5.0

gulpjs/gulp#2777 (comment)

https://medium.com/gulpjs/announcing-gulp-v5-c67d077dbdb7

Can be tested by running npm run build-gh-release then opening the nhs-logo.png in the dist/assets/logos directory or unzipping nhsuk-frontend-8.3.0.zip and then opening the png

Fixes #1009

Checklist

@chrimesdev
Copy link
Member Author

Pipeline failing due to Sonar analysis - Set the SONAR_TOKEN env variable.

Maybe because its a fork? 🤷🏻‍♂️

frankieroberto
frankieroberto previously approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@frankieroberto frankieroberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified by running this locally, thanks!

@frankieroberto
Copy link
Contributor

Pipeline failing due to Sonar analysis - Set the SONAR_TOKEN env variable.

Maybe because its a fork? 🤷🏻‍♂️

Ah yeah, this is a known issue. 😢 I think an admin of this repo can override and merge anyway?

@mikemonteith
Copy link
Contributor

it's a sad day when @chrimesdev himself is reduced to creating forks to submit PRs on this

@chrimesdev
Copy link
Member Author

chrimesdev commented Sep 9, 2024 •
edited
Loading

it's a sad day when @chrimesdev himself is reduced to creating forks to submit PRs on this

this was my 1001st commit on this repository

@frankieroberto frankieroberto mentioned this pull request Sep 9, 2024
Open
@frankieroberto
Copy link
Contributor

I've pulled this commit into another branch, and opened another pull request, to workaround the issue with running sonar on the fork: #1013

@frankieroberto frankieroberto mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemonteith mikemonteith mikemonteith approved these changes

@frankieroberto frankieroberto frankieroberto left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.png files in zip release are corrupted
3 participants
@chrimesdev @frankieroberto @mikemonteith