Fix encoding issue introduce in gulp v5.0 #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankieroberto
changed the title
3 tasks
mikemonteith
approved these changes
Sep 10, 2024
edwardhorsford
added a commit
that referenced
this pull request
Sep 19, 2024
…tend into add-task-list-component * 'add-task-list-component' of github.com:nhsuk/nhsuk-frontend: (34 commits) Fix encoding issue introduce in gulp v5.0 (#1013) Make it easier to set date values (#994) Update app/components/task-list/multiple-sections.njk Update packages/components/task-list/_task-list.scss Update packages/components/task-list/_task-list.scss Update app/components/task-list/multiple-sections.njk Add summary list row classes (#1007) Add summary list row condition (#1008) changelog backstop refs backstop refs change margins to padding still trying to fix linting error backstop refs remove testing markup from component examples backstop refs updated Use page template in examples update reference images tweak main wrapper margin reduce the padding on main wrapper on mobile ...
frankieroberto
added a commit
to NHSDigital/record-a-vaccination-prototype
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix encoding issue introduced in Gulp v5.0
gulpjs/gulp#2777 (comment)
https://medium.com/gulpjs/announcing-gulp-v5-c67d077dbdb7
Can be tested by running
npm run build-gh-releasethen opening thenhs-logo.pngin thedist/assets/logosdirectory or unzippingnhsuk-frontend-8.3.0.zipand then opening thepngFixes #1009
Checklist