Add get_channel_names to niscope API #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ni-jfitzger
commented
Apr 29, 2023
3 tasks
ni-jfitzger
commented
May 1, 2023
marcoskirsch
requested changes
May 1, 2023
marcoskirsch
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add the
get_channel_namesmethod to the niscope API. Per the decision made in #1386,get_channel_nameandget_channel_name_from_stringwill not be added. This will be the only entrypoint for translating channel indices to names.Implementation:
Copied the current metadata from nidigital and tweaked parameter names and some hidden parameter documentation for niscope.
List issues fixed by this Pull Request below, if any.
What testing has been done?
test_get_channel_namesfrom nidigital and modified it for niscope. It passes.