-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
niscope: expand channels repeated_capability before populating channel and record info in fetched data #1958
Conversation
…nto niscope_fetch_fixes
…nto niscope_fetch_fixes
If this is fixing a bug, how come it does not add a test that would fail without the bugfix? |
@marcoskirsch That's what the change to src/niscope/system_tests/test_system_niscope.py does. The test changes to catch the bug were implemented in #1956 with failing parameter values commented out, so that we wouldn't submit failing tests. Since we are fixing the bug here, I restored the failing parameter values. |
What does this Pull Request accomplish?
Based on how nidcpower does things for
fetch_multiple
,measure_multiple
, etc., expand the _repeated_capability (channels) before trying to do anything with it, other than pass it to a driver function.The driver knows how to handle unexpanded channel strings (or it will error if it can't), but the simple code in
_populate_channel_and_record_info
assumes that all channels in thechannels
iterable are individual channels.List issues fixed by this Pull Request below, if any.
What testing has been done?
fetch()
orget_channel_names
will error, so no bad data. Passing test_channels: '0:1', test_channels_expanded:0,1
totest_fetch
, passed.