Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pytest setup fixture to ensure .env file exists #290

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Add pytest setup fixture to ensure .env file exists #290

merged 2 commits into from
Sep 21, 2023

Conversation

annshress
Copy link
Collaborator

@annshress annshress commented Aug 29, 2023 •
edited
Loading

… with appropriate variables

Addresses #287

Changes

  • Removes monkeypatching config in pytest
  • Mandates .env files (checked only during pytest)

This PR doesn't introduce any:

  • Binary files
  • Temporary files, auto-generated files
  • Secret keys
  • Local debugging print statements
  • Unwanted comments (e.g: # Gets user from environment for code os.environ['user'] )

This PR contains valid:

  • tests

@annshress annshress marked this pull request as ready for review August 29, 2023 20:36
@annshress annshress force-pushed the feature/preflight_env branch from 9696cbf to 006199a Compare September 11, 2023 20:25
@annshress annshress marked this pull request as draft September 11, 2023 20:30
@annshress annshress marked this pull request as ready for review September 11, 2023 20:33
@annshress annshress force-pushed the feature/preflight_env branch from 006199a to ed5ec41 Compare September 21, 2023 14:23
@niaid niaid deleted a comment from github-actions bot Sep 21, 2023
@github-actions
Copy link

Coverage report

The coverage rate went from 67.12% to 26.89% ⬇️
The branch rate is 13%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@philipmac philipmac merged commit fec2031 into main Sep 21, 2023
2 checks passed
@philipmac philipmac deleted the feature/preflight_env branch September 21, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipmac philipmac philipmac approved these changes

@mbopfNIH mbopfNIH Awaiting requested review from mbopfNIH

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annshress @philipmac