Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No comment syntax configured #12

Closed
aspiwack opened this issue Apr 29, 2024 · 3 comments · Fixed by #13
Closed

No comment syntax configured #12

aspiwack opened this issue Apr 29, 2024 · 3 comments · Fixed by #13

Comments

@aspiwack
Copy link
Contributor

I'm noticing that if I call comment-region (generally invoked via comment-dwim/M-;), there is no comment syntax configured.

I don't have time right now to figure what invocation to add to the mode for that to happen. So just leaving an issue rather than what must be a rather straightforward PR.

@purcell
Copy link
Collaborator

purcell commented Apr 29, 2024

Probably need to set comment-start to "# " and comment-end to "" here. Reload the elisp, reapply in a nickel-mode buffer with M-x normal-mode. If it doesn't work, probably means that the syntax-propertize function needs to be extended.

aspiwack added a commit that referenced this issue May 14, 2024
@aspiwack
Copy link
Contributor Author

Indeed, it worked like a charm. Thanks for the tip!

@purcell
Copy link
Collaborator

purcell commented May 14, 2024

yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants