Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment delimiters #13

Merged
merged 1 commit into from
May 14, 2024
Merged

Add comment delimiters #13

merged 1 commit into from
May 14, 2024

Conversation

aspiwack
Copy link
Contributor

Closes #12.

@aspiwack aspiwack merged commit 7144128 into main May 14, 2024
6 checks passed
@aspiwack aspiwack deleted the comment-delimiters branch May 14, 2024 12:37
@purcell
Copy link
Collaborator

purcell commented May 14, 2024

You might also consider setting comment-start-skip to "#+\\s-*".

@aspiwack
Copy link
Contributor Author

I checked the documentation before writing my PR, and my understanding was that comment-start-skip was to detect already commented bits for comment-dwim. I checked that comment-dwim worked fine (it did), so I didn't bother with comment-start-skip. Did I miss something?

@purcell
Copy link
Collaborator

purcell commented May 14, 2024

Hmm, I don't know — most modes I've seen tend to set up both vars, so the cargo cult wisdom is apparently that only comment-start is required, but that it is Good Practice™ to set comment-start-skip too. I confess to being unaware of the specific reasons, if any actually exist. 😅

@aspiwack
Copy link
Contributor Author

Ok. Then, with your permission, I'm going to Ockham-razor this one, and leave comment-start-skip out until something goes wrong 🙂 .

@purcell
Copy link
Collaborator

purcell commented May 14, 2024

Haha, you certainly don't need my blessing to ignore this entirely for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No comment syntax configured
3 participants