Add parsing of compiler directive `default_nettype #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickg
reviewed
Jan 27, 2025
src/scan.h
Outdated
| #define tPLUSPLUS 524 | ||
| #define tMINUSMINUS 525 | ||
| #define tVAR 526 | ||
| #define tDEFAULTNETTYPE 527 |
There was a problem hiding this comment.
Suggested change
| #define tDEFAULTNETTYPE 527 | |
| #define tDEFNETTYPE 527 |
Give it a slightly shorter name then you don't need to reindent all the other ones.
There was a problem hiding this comment.
Sure it should be changes now, I wasn’t sure it was ok to shorten the constant name so I went with the full one even if I had to re-indent.
Anselmo95
force-pushed
the
defaultnettype
branch
from
b4aa0fd to
2a9df0a
Compare
I know it's not around the corner but curiosity got the better of me and honestly it already parses 10% of single file, It's not bad ! |
Anselmo95
force-pushed
the
defaultnettype
branch
from
2a9df0a to
bb569f9
Compare
Anselmo95
force-pushed
the
defaultnettype
branch
from
bb569f9 to
c38013e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried analysing the xpm models provided with vivado just to see how far I could get and the
default_nettypeis the first problem it encounters.I tried to add just enough logic to parse the directive correctly but I have no idea how to use the parsed information so this is ad far as I can go for the moment.
According to what I found online this is the notation: