Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HomeRootView.swift #105

Conversation

nicolevanelstvandenhoek

Used more style full icons from SF-Symbols.

Used more style full icons from SF-Symbols.
@MikePlante1
Copy link
Contributor

MikePlante1 commented Apr 14, 2024

Looks like this is what's changed by the PR: (EDIT: screenshots from iPhone 15 simulator)

new-light new-dark

Currently dev looks like this:
old-light
old-dark

@bjornoleh
Copy link
Contributor

Thanks for the suggestion. We have agreed to not change anything UI related before the first release, simply because we are short on time and UI changes tend to take time and divert attention from more pressing matters. Let’s revisit this a little later 😊

@nicolevanelstvandenhoek
Copy link
Author

I understand that it is not a priority. Therefore, it is very good that those who do the content development deal with the more complicated stuff. I don't have that knowledge, but I do have a lot of feel for the UI and thus can't disrupt much of the real development work either. In short, I have the time and inclination to help work on a nice UI.

@Sjoerd-Bo3
Copy link
Contributor

I understand that it is not a priority. Therefore, it is very good that those who do the content development deal with the more complicated stuff. I don't have that knowledge, but I do have a lot of feel for the UI and thus can't disrupt much of the real development work either. In short, I have the time and inclination to help work on a nice UI.

Thanks great, But it also means that it probably won't make it in before 1.0.0 . A whole rework is coming after 1.0.0 aswell.

@dnzxy
Copy link
Contributor

dnzxy commented May 11, 2024

To give constructive criticism to this PR:

The insulin vial icon is skewed. That is due to using .frame(width: 24, height: 24) with SF Symbols. Please refrain from doing that and style, i.e. set icon sizes, by using font size, as SF Symbols "behave" just like fonts.

Just as an example:

Image(systemName: "cross.vial.fill").font(.system(size: 25))

Is it okay if we close this PR here for now?

@dnzxy
Copy link
Contributor

dnzxy commented May 12, 2024

Closing for now with 2 thumbs up, one by PR author. Thanks guys.

@dnzxy dnzxy closed this May 12, 2024
mountrcg pushed a commit to mountrcg/Trio that referenced this pull request Aug 1, 2024
…cout#9 & nightscout#18 and MinimedKit PR nightscout#6 (nightscout#438)

+ Extend low reservoir notification range
+ Prevent negative duration doses, which can happen if the phone clock is changed
+ Fixes Loop crash when changing time back and cancelling bolus, Loop Issue #2057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants