Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease HealthKitManager debug logging #372

Merged
merged 2 commits into from
Aug 4, 2024
Merged

Decrease HealthKitManager debug logging #372

merged 2 commits into from
Aug 4, 2024

Conversation

marionbarker
Copy link
Contributor

@marionbarker marionbarker commented Aug 3, 2024 •
edited
Loading

  • disable some debug logging when AppleHealth is enabled

See Issue #371 for explanation for this PR.

Additional comments

  • most of the excessive lines came in as debug logging in PR Backport HealthKit fix to earlier version #22
  • other debug log lines have been removed over time in various commits
  • these particular lines were identified by @itsmojo as being unnecessary when he analyzed results

Testing

  • I confirmed the extra lines appeared when Apple Health and Dynamic Features are enabled
  • I tested the patch supplied by @itsmojo and confirm the excessive debug logging (for this case) is removed

@marionbarker
decrease logging
7106a91 
* disable some debug logging when AppleHealth and Dynamic features are enabled
@AndreasStokholm
Copy link
Contributor

Seeing as PR 22 is merged quite a while in the past and it seems to be stable. Maybe the debugging I added can be removed completely instead of just commenting it out.

@marionbarker
Copy link
Contributor Author

marionbarker commented Aug 3, 2024 •
edited
Loading

Deleted comment. Got help from Joe.

@marionbarker
Copy link
Contributor Author

Ready for review again. I removed the debug lines instead of commenting them out.

MikePlante1
MikePlante1 approved these changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@MikePlante1 MikePlante1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree those logs aren't needed and the PR only removes debug() lines. Successful build to a simulator to confirm lint-free.

@MikePlante1 MikePlante1 merged commit 0efde61 into nightscout:dev Aug 4, 2024
1 check passed
@marionbarker marionbarker mentioned this pull request Aug 4, 2024
Closed
@MikePlante1 MikePlante1 mentioned this pull request Aug 17, 2024
Merged
mountrcg pushed a commit to mountrcg/Trio that referenced this pull request Sep 11, 2024
@MikePlante1 @mountrcg
Merge pull request nightscout#372 from loopandlearn/remove-excessive-…
755d73f 
…logging

Decrease HealthKitManager debug logging
@marionbarker marionbarker deleted the remove-excessive-logging branch October 3, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikePlante1 MikePlante1 MikePlante1 approved these changes

@itsmojo itsmojo itsmojo approved these changes

@aug0211 aug0211 aug0211 approved these changes

@dnzxy dnzxy Awaiting requested review from dnzxy dnzxy is a code owner

@bjornoleh bjornoleh Awaiting requested review from bjornoleh bjornoleh is a code owner

@AndreasStokholm AndreasStokholm Awaiting requested review from AndreasStokholm AndreasStokholm is a code owner

@Sjoerd-Bo3 Sjoerd-Bo3 Awaiting requested review from Sjoerd-Bo3 Sjoerd-Bo3 is a code owner

@t1dude t1dude Awaiting requested review from t1dude t1dude is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marionbarker @AndreasStokholm @aug0211 @itsmojo @MikePlante1