Remove actualDate as introduced in #22
#55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed in conjunction with nightscout/trio-oref#14
|
Accidentally created the PR from my fork, but the same branch is available at https://github.com/nightscout/Open-iAPS/tree/remove_actualDate |
bjornoleh
commented
Apr 6, 2024
|
I pushed in the branch remove_actualDate some fix : see f5d301e Idid some tests described here using the corrected version of oref :
|
- allows to add carbs in past or future - allows to add FPU only use createdAt attribute
11 tasks
|
the initial branch submodule+oref contains some modified code not included in this PR/branch. I create a new PR : #56 |
AndreasStokholm
approved these changes
Apr 8, 2024
|
@avouspierre , I guess this is ready to be merged into dev? |
|
👍 |
|
Thanks! Merging this with two approvals. |
Merged
bjornoleh
added a commit
that referenced
this pull request
Apr 11, 2024
Merge pull request #55 from bjornoleh/remove_actualDate
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed in conjunction with nightscout/trio-oref#14