Emit error - Multiple properties cannot share the same hooks

Closes GH-1052.
nikic · Dec 27, 2024 · d20a197 · d20a197
1 parent 62dee28
commit d20a197
Show file tree

Hide file tree

Showing 4 changed files with 122 additions and 0 deletions.
diff --git a/grammar/php.y b/grammar/php.y
@@ -840,6 +840,7 @@ class_statement:
 #if PHP8
     | optional_attributes variable_modifiers optional_type_without_static property_declaration_list '{' property_hook_list '}'
           { $$ = new Stmt\Property($2, $4, attributes(), $3, $1, $6);
+            $this->checkPropertyHooksForMultiProperty($$, #5);
             $this->checkEmptyPropertyHookList($6, #5); }
 #endif
     | optional_attributes method_modifiers T_CONST class_const_list semi

diff --git a/lib/PhpParser/Parser/Php8.php b/lib/PhpParser/Parser/Php8.php
@@ -1993,6 +1993,7 @@ protected function initReduceCallbacks(): void {
             },
             348 => static function ($self, $stackPos) {
                  $self->semValue = new Stmt\Property($self->semStack[$stackPos-(7-2)], $self->semStack[$stackPos-(7-4)], $self->getAttributes($self->tokenStartStack[$stackPos-(7-1)], $self->tokenEndStack[$stackPos]), $self->semStack[$stackPos-(7-3)], $self->semStack[$stackPos-(7-1)], $self->semStack[$stackPos-(7-6)]);
+            $self->checkPropertyHooksForMultiProperty($self->semValue, $stackPos-(7-5));
             $self->checkEmptyPropertyHookList($self->semStack[$stackPos-(7-6)], $stackPos-(7-5));
             },
             349 => static function ($self, $stackPos) {

diff --git a/lib/PhpParser/ParserAbstract.php b/lib/PhpParser/ParserAbstract.php
@@ -1158,6 +1158,13 @@ protected function checkUseUse(UseItem $node, int $namePos): void {
         }
     }
 
+    protected function checkPropertyHooksForMultiProperty(Property $property, int $hookPos): void {
+        if (count($property->props) > 1) {
+            $this->emitError(new Error(
+                'Cannot use hooks when declaring multiple properties', $this->getAttributesAt($hookPos)));
+        }
+    }
+
     /** @param PropertyHook[] $hooks */
     protected function checkEmptyPropertyHookList(array $hooks, int $hookPos): void {
         if (empty($hooks)) {

diff --git a/test/code/parser/stmt/class/property_hooks.test b/test/code/parser/stmt/class/property_hooks.test
@@ -523,3 +523,116 @@ array(
         )
     )
 )
+-----
+<?php
+class Test
+{
+
+    public $foo, $bar { get { return 42; } }
+
+}
+-----
+Cannot use hooks when declaring multiple properties from 5:23 to 5:23
+array(
+    0: Stmt_Class(
+        attrGroups: array(
+        )
+        flags: 0
+        name: Identifier(
+            name: Test
+        )
+        extends: null
+        implements: array(
+        )
+        stmts: array(
+            0: Stmt_Property(
+                attrGroups: array(
+                )
+                flags: PUBLIC (1)
+                type: null
+                props: array(
+                    0: PropertyItem(
+                        name: VarLikeIdentifier(
+                            name: foo
+                        )
+                        default: null
+                    )
+                    1: PropertyItem(
+                        name: VarLikeIdentifier(
+                            name: bar
+                        )
+                        default: null
+                    )
+                )
+                hooks: array(
+                    0: PropertyHook(
+                        attrGroups: array(
+                        )
+                        flags: 0
+                        byRef: false
+                        name: Identifier(
+                            name: get
+                        )
+                        params: array(
+                        )
+                        body: array(
+                            0: Stmt_Return(
+                                expr: Scalar_Int(
+                                    value: 42
+                                )
+                            )
+                        )
+                    )
+                )
+            )
+        )
+    )
+)
+-----
+<?php
+class Test
+{
+
+    public $foo, $bar { }
+
+}
+-----
+Cannot use hooks when declaring multiple properties from 5:23 to 5:23
+Property hook list cannot be empty from 5:23 to 5:23
+array(
+    0: Stmt_Class(
+        attrGroups: array(
+        )
+        flags: 0
+        name: Identifier(
+            name: Test
+        )
+        extends: null
+        implements: array(
+        )
+        stmts: array(
+            0: Stmt_Property(
+                attrGroups: array(
+                )
+                flags: PUBLIC (1)
+                type: null
+                props: array(
+                    0: PropertyItem(
+                        name: VarLikeIdentifier(
+                            name: foo
+                        )
+                        default: null
+                    )
+                    1: PropertyItem(
+                        name: VarLikeIdentifier(
+                            name: bar
+                        )
+                        default: null
+                    )
+                )
+                hooks: array(
+                )
+            )
+        )
+    )
+)