Reject multi hooked property #1052
Closed
+127
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Dec 13, 2024
| protected function checkPropertyHooksForMultiProperty(Property $property): void { | ||
| if (count($property->props) > 1) { | ||
| $this->emitError(new Error( | ||
| 'Multiple properties cannot share the same hooks', $property->getAttributes())); |
There was a problem hiding this comment.
This is marking the entire property as the error location. This should probably use the opening brace of the hooks instead, like the one below. (Or alternatively the name of the second property, not sure which is better.)
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1050