Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update results for 4th run #4

Closed
wants to merge 8 commits into from
Closed

Update results for 4th run #4

wants to merge 8 commits into from

Conversation

lqd
Copy link
Contributor

@lqd lqd commented Aug 29, 2018 •
edited
Loading

  1. proptest-arbitrary:
  • The first repro collates the necessary parts from proptest-arbitrary and proptest and reproduces faithfully the messages from the crater run.
  • The second repro is a bit more minimal, while still behaving differently under AST borrowck, but partially automatically reduced to focus on one of the two identical errors.

  1. LocustDB:
    Now builds successfully 🎉

  2. pom:
    added minimized repro, it also shows the diagnostics I was wondering about: is there no information on where the '2 region comes from ?

  3. chiisai and fred: known fixed-by-nll Bug: nested closure outlives borrowed value. rust-lang/rust#53432. fred has 2 repros, one more faithful to hyper/futures and one more minimal. There is no repro for chiisai, but it's clear it's the same issue/pattern of a hyper-0.11.0 server done with a closure.

  4. ocl and gluon_vm: look fixed-by-nll. guon has 3 repros, as there are different 3 errors.

  5. added all the failing crates' logs, so this one commit kinds steps on the toes of everything else

Since I tend to lose the WIP notes/documents, here are: the one for the 3rd run and for the 4th run.

@lqd
Update results for proptest-arbitrary
af44153 
The first repro collates the necessary parts from `proptest-arbitrary` and `proptest` and reproduces faithfully the messages from the crater run.

The second repro is a bit more minimal, while still behaving differently under AST borrowck, but partially automatically reduced to focus on one of the two identical errors.
@lqd lqd force-pushed the proptest-arbitrary branch from 40b71bf to af44153 Compare August 29, 2018 14:40
@lqd
LocustDB builds now
61ef83d 
Sucessfully built in the 4th crater run
@lqd lqd changed the title Update results for proptest-arbitrary Update results for proptest-arbitrary and LocustDB Sep 15, 2018
@lqd lqd changed the title Update results for proptest-arbitrary and LocustDB Update results Sep 15, 2018
@lqd lqd changed the title Update results Update results for 4th run Sep 17, 2018
nikomatsakis
nikomatsakis approved these changes Sep 18, 2018
View reviewed changes
README.md Outdated
@@ -112,3 +112,4 @@
[#53789]: https://github.com/rust-lang/rust/issues/53789
[18]: https://play.rust-lang.org/?gist=c990af931ab56d93207efcade0ffd01b&version=nightly&mode=debug&edition=2015
[19]: https://play.rust-lang.org/?gist=1f1d03d4f8280b8843594cba668c9db4&version=nightly&mode=debug&edition=2015
[20]: https://play.rust-lang.org/?gist=c6a5e5dcf99e04855350770b62528486&version=nightly&mode=debug&edition=2015
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see discussion on Zulip. The TL;DR:

  • Diagnostics have an immediate problem of printing '_ but referencing '_2
  • Plus the diagnostic is ungreat: it should talk about how '1 is local to the closure but escapes in the return type
  • The error itself seems unfortunate but basically correct

README.md Outdated
@@ -119,3 +120,6 @@
[#53432]: https://github.com/rust-lang/rust/issues/53432
[21]: https://play.rust-lang.org/?gist=448e4a6646e0048b027b03f607a612dc&version=nightly&mode=debug&edition=2015
[22]: https://play.rust-lang.org/?gist=b61db3de15c2c0716d76d7e5df9abb02&version=nightly&mode=debug&edition=2015
[23]: https://play.rust-lang.org/?gist=2869a3fead3981815e077700d68de8eb&version=nightly&mode=debug&edition=2015
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirm, correct for us to error

README.md Outdated
@@ -119,3 +120,6 @@
[#53432]: https://github.com/rust-lang/rust/issues/53432
[21]: https://play.rust-lang.org/?gist=448e4a6646e0048b027b03f607a612dc&version=nightly&mode=debug&edition=2015
[22]: https://play.rust-lang.org/?gist=b61db3de15c2c0716d76d7e5df9abb02&version=nightly&mode=debug&edition=2015
[23]: https://play.rust-lang.org/?gist=2869a3fead3981815e077700d68de8eb&version=nightly&mode=debug&edition=2015
[24]: https://play.rust-lang.org/?gist=d404421b51edcb0c2d6fb700a313be95&version=nightly&mode=debug&edition=2015
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirm, error looks correct, though it is not rust-lang/rust#52059 — I'm not sure what AST bug this is. Looks like something to do with DerefMut...?

README.md Outdated
@@ -119,3 +120,6 @@
[#53432]: https://github.com/rust-lang/rust/issues/53432
[21]: https://play.rust-lang.org/?gist=448e4a6646e0048b027b03f607a612dc&version=nightly&mode=debug&edition=2015
[22]: https://play.rust-lang.org/?gist=b61db3de15c2c0716d76d7e5df9abb02&version=nightly&mode=debug&edition=2015
[23]: https://play.rust-lang.org/?gist=2869a3fead3981815e077700d68de8eb&version=nightly&mode=debug&edition=2015
[24]: https://play.rust-lang.org/?gist=d404421b51edcb0c2d6fb700a313be95&version=nightly&mode=debug&edition=2015
[25]: https://play.rust-lang.org/?gist=f16c92102d7c16ec4feda59814ba7cf9&version=nightly&mode=debug&edition=2015
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirm, same bug as [24]

README.md Outdated
@@ -123,3 +124,4 @@
[23]: https://play.rust-lang.org/?gist=2869a3fead3981815e077700d68de8eb&version=nightly&mode=debug&edition=2015
[24]: https://play.rust-lang.org/?gist=d404421b51edcb0c2d6fb700a313be95&version=nightly&mode=debug&edition=2015
[25]: https://play.rust-lang.org/?gist=f16c92102d7c16ec4feda59814ba7cf9&version=nightly&mode=debug&edition=2015
[26]: https://play.rust-lang.org/?gist=1ddf9aa2d1bc3e96066576c2b4b05df3&version=nightly&mode=debug&edition=2015
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirm, probably rust-lang/rust#38899

README.md Outdated
@@ -113,3 +114,5 @@
[18]: https://play.rust-lang.org/?gist=c990af931ab56d93207efcade0ffd01b&version=nightly&mode=debug&edition=2015
[19]: https://play.rust-lang.org/?gist=1f1d03d4f8280b8843594cba668c9db4&version=nightly&mode=debug&edition=2015
[20]: https://play.rust-lang.org/?gist=c6a5e5dcf99e04855350770b62528486&version=nightly&mode=debug&edition=2015
[chiisai]: https://crater-reports.s3.amazonaws.com/pr-53426-2/try%23e3ede4ae5297558caacf160ecf523f3a5759f682/reg/chiisai-0.1.6/log.txt
[#53432]: https://github.com/rust-lang/rust/issues/53432
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirm

README.md Outdated
@@ -41,6 +40,7 @@
| `ilp-packet` | 0.3.0 | F | [4][] | | FIXME: find an issue link |
| `jmespath-macros` | 0.1.1 | + | | | |
| `liner` | 0.4.4 | F | [17][] | | |
| `LocustDB` | c59429 | + | [11][] | [#53570][] | |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

README.md Outdated
@@ -116,3 +117,5 @@
[20]: https://play.rust-lang.org/?gist=c6a5e5dcf99e04855350770b62528486&version=nightly&mode=debug&edition=2015
[chiisai]: https://crater-reports.s3.amazonaws.com/pr-53426-2/try%23e3ede4ae5297558caacf160ecf523f3a5759f682/reg/chiisai-0.1.6/log.txt
[#53432]: https://github.com/rust-lang/rust/issues/53432
[21]: https://play.rust-lang.org/?gist=448e4a6646e0048b027b03f607a612dc&version=nightly&mode=debug&edition=2015
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirm

README.md Outdated
@@ -116,3 +117,5 @@
[20]: https://play.rust-lang.org/?gist=c6a5e5dcf99e04855350770b62528486&version=nightly&mode=debug&edition=2015
[chiisai]: https://crater-reports.s3.amazonaws.com/pr-53426-2/try%23e3ede4ae5297558caacf160ecf523f3a5759f682/reg/chiisai-0.1.6/log.txt
[#53432]: https://github.com/rust-lang/rust/issues/53432
[21]: https://play.rust-lang.org/?gist=448e4a6646e0048b027b03f607a612dc&version=nightly&mode=debug&edition=2015
[22]: https://play.rust-lang.org/?gist=b61db3de15c2c0716d76d7e5df9abb02&version=nightly&mode=debug&edition=2015
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirm

@lqd lqd closed this Nov 21, 2023
@lqd lqd deleted the proptest-arbitrary branch November 21, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lqd @nikomatsakis