Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update results for 4th run #4

Closed
wants to merge 8 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
| `extended-collections` | 0.1.0 | F | | [#51915][] | wants a more aggressive 2PB |
| `extended-collections` | 0.2.0 | F | [9][] | [#51915][] | wants a more aggressive 2PB |
| `fractions_and_matrices` | 2ea35 | F | | | [#47349][] (diagnostics)
| `fred` | 0.1.6 | F | [21][] [22][] | | [#53432][]
| `fscmp` | 0.1.1 | + | | | |
| `galvanize` | 0.0.1 | F | [10][] | | [#52059][] (diagnostics) |
| `gearley` | 0.0.1 | F | | | |
Expand Down Expand Up @@ -116,3 +117,5 @@
[20]: https://play.rust-lang.org/?gist=c6a5e5dcf99e04855350770b62528486&version=nightly&mode=debug&edition=2015
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see discussion on Zulip. The TL;DR:

  • Diagnostics have an immediate problem of printing '_ but referencing '_2
  • Plus the diagnostic is ungreat: it should talk about how '1 is local to the closure but escapes in the return type
  • The error itself seems unfortunate but basically correct

[chiisai]: https://crater-reports.s3.amazonaws.com/pr-53426-2/try%23e3ede4ae5297558caacf160ecf523f3a5759f682/reg/chiisai-0.1.6/log.txt
[#53432]: https://github.com/rust-lang/rust/issues/53432
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirm

[21]: https://play.rust-lang.org/?gist=448e4a6646e0048b027b03f607a612dc&version=nightly&mode=debug&edition=2015
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirm

[22]: https://play.rust-lang.org/?gist=b61db3de15c2c0716d76d7e5df9abb02&version=nightly&mode=debug&edition=2015
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirm