Dedup group members #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before adding accidentally a group twice to a user resulted in the following: Updating members of group mygroup from ["sandro"] to ["sandro", "sandro"]... Which was also twice in /etc/groups: mygroup:x:999:sandro,sandro With this patch this gets deduplicated and fixed: <6>Updating members of group mygroup from ["sandro", "sandro"] to ["sandro"]... mygroup:x:999:sandro
|
ping @nikstur |
|
Thx for the contribution and sorry for not looking at it sooner! |
|
We should also probably sort the groups, otherwise dedup doesn't work in all cases
https://doc.rust-lang.org/std/vec/struct.Vec.html#method.dedup |
|
Is it like the uniq unix command? I didn't even think about that.... |
|
HashSet might be than the better choice. Also this could be potentially already sorted by nix if it was derived from an attrset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before adding accidentally a group twice to a user resulted in the following:
Updating members of group mygroup from ["sandro"] to ["sandro", "sandro"]...
Which was also twice in /etc/groups:
mygroup:x:999:sandro,sandro
With this patch this gets deduplicated and fixed:
<6>Updating members of group mygroup from ["sandro", "sandro"] to ["sandro"]... mygroup:x:999:sandro