-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
userborn: enable by default #575
base: main
Are you sure you want to change the base?
Conversation
72aad6a
to
645f812
Compare
Causes nixos-rebuild switch / nixos-rebuild-switch-to-configuration.service to fail? I tried it on build01:
|
What is the failure? We should probably report issues like this. |
|
@zowoq are you sure this is caused by userborn? |
Yes. |
The error message doesn't give anything away. I would have expected all userborn runs to also have an error message. |
The only exit code here is 1: https://github.com/nikstur/userborn/blob/2c4dca6cac5e974727e2b6b22bab2fd2ebe991f3/rust/userborn/src/main.rs#L55 |
I tried enabling it on a personal system and build04, same error on both. |
Ok. This is reason enough to not enable it by default for now. |
@mergify queue |
🛑 The pull request has been removed from the queue
|
@mergify queue |
🛑 The pull request has been removed from the queue
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
I have tested this for a wile without any issues. If it works find in srvos, we can propose this to nixos itself. Co-authored-by: zowoq <59103226+zowoq@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my config this just worked but it still feels a bit "alpha" or at least beta
How so? I am using this since September without any issues? |
Found a small issue nikstur/userborn#14 but maybe I just forget about it in the next weeks and it really just works. |
I have tested this for a wile without any issues.
If it works find in srvos, we can propose this to nixos itself.