Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userborn: enable by default #575

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

userborn: enable by default #575

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 2, 2024

I have tested this for a wile without any issues.
If it works find in srvos, we can propose this to nixos itself.

@Mic92 Mic92 force-pushed the userborn branch 2 times, most recently from 72aad6a to 645f812 Compare December 2, 2024 10:29
nixos/common/default.nix Outdated Show resolved Hide resolved
@zowoq
Copy link
Contributor

zowoq commented Dec 5, 2024

Causes nixos-rebuild switch / nixos-rebuild-switch-to-configuration.service to fail?

I tried it on build01:

switch fails.

boot works but then running switch again (switching into the current booted generation) fails?

@Mic92
Copy link
Member Author

Mic92 commented Dec 6, 2024

What is the failure? We should probably report issues like this.

@zowoq
Copy link
Contributor

zowoq commented Dec 6, 2024

Dec 05 00:42:37 build01 systemd[1]: Starting /nix/store/k88rz3p58mp584jd0v63wlxx3vja2fwg-nixos-system-build01-25.05.20241201.767b0e3/bin/switch-to-configuration switch...
Dec 05 00:42:37 build01 systemd[1]: Started /nix/store/k88rz3p58mp584jd0v63wlxx3vja2fwg-nixos-system-build01-25.05.20241201.767b0e3/bin/switch-to-configuration switch.
Dec 05 00:42:38 build01 nixos[4248]: switching to system configuration /nix/store/k88rz3p58mp584jd0v63wlxx3vja2fwg-nixos-system-build01-25.05.20241201.767b0e3
Dec 05 00:42:40 build01 nixos[4248]: switching to system configuration /nix/store/k88rz3p58mp584jd0v63wlxx3vja2fwg-nixos-system-build01-25.05.20241201.767b0e3 failed (status 2)
Dec 05 00:42:40 build01 systemd[1]: nixos-rebuild-switch-to-configuration.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Dec 05 00:42:40 build01 systemd[1]: nixos-rebuild-switch-to-configuration.service: Failed with result 'exit-code'.

@Mic92
Copy link
Member Author

Mic92 commented Dec 6, 2024

@zowoq are you sure this is caused by userborn?

@zowoq
Copy link
Contributor

zowoq commented Dec 6, 2024

Yes.

@Mic92
Copy link
Member Author

Mic92 commented Dec 6, 2024

The error message doesn't give anything away. I would have expected all userborn runs to also have an error message.

@Mic92
Copy link
Member Author

Mic92 commented Dec 6, 2024

The only exit code here is 1: https://github.com/nikstur/userborn/blob/2c4dca6cac5e974727e2b6b22bab2fd2ebe991f3/rust/userborn/src/main.rs#L55
And it should always print an error. The activation script exits with 2 however.

@zowoq
Copy link
Contributor

zowoq commented Dec 6, 2024

I tried enabling it on a personal system and build04, same error on both.

@Mic92
Copy link
Member Author

Mic92 commented Dec 11, 2024

Ok. This is reason enough to not enable it by default for now.

nixos/common/default.nix Outdated Show resolved Hide resolved
@Mic92
Copy link
Member Author

Mic92 commented Dec 17, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Dec 17, 2024

queue

🛑 The pull request has been removed from the queue default

The pull request #575 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@Mic92
Copy link
Member Author

Mic92 commented Dec 17, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Dec 17, 2024

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

Copy link
Contributor

mergify bot commented Dec 17, 2024

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

I have tested this for a wile without any issues.
If it works find in srvos, we can propose this to nixos itself.

Co-authored-by: zowoq <59103226+zowoq@users.noreply.github.com>
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my config this just worked but it still feels a bit "alpha" or at least beta

@Mic92
Copy link
Member Author

Mic92 commented Dec 17, 2024

For my config this just worked but it still feels a bit "alpha" or at least beta

How so? I am using this since September without any issues?

@SuperSandro2000
Copy link
Member

Found a small issue nikstur/userborn#14 but maybe I just forget about it in the next weeks and it really just works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants