Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testament r doesn't honor --targets:js nor what's in the spec #14242

Closed
timotheecour opened this issue May 6, 2020 · 1 comment · Fixed by #16163
Closed

testament r doesn't honor --targets:js nor what's in the spec #14242

timotheecour opened this issue May 6, 2020 · 1 comment · Fixed by #16163
Labels
Medium Priority Test Suite

Comments

@timotheecour
Copy link
Member

timotheecour commented May 6, 2020 •
edited
Loading

testament r doesn't honor --targets:js nor what's in the spec

Example

testament/testament --targets:js r tests/js/t7224.nim

Current Output

runs C target

Expected Output

runs js target: both because of --target:js and because the test would normally run via js

Additional Information

D20200505T030352

this makes it inconvenient to run a test locally, maybe I'm missing some option?
This was referenced May 6, 2020
Closed
Open
@timotheecour
Copy link
Member Author

timotheecour commented Nov 28, 2020 •
edited
Loading

I keep hitting this.
eg:

XDG_CONFIG_HOME= nim r testament/testament r tests/js/tunittests.nim

this one reflects 2 bugs: this bug, and the fact that unittest works differently for js vs non-js, giving different results because:

  • testament sets NIMTEST_OUTPUT_LVL
  • unittest honors NIMTEST_OUTPUT_LVL only for non-js

instead a defined(NIMTEST_OUTPUT_LVL) (or a better name) would be the correct approach here

EDIT: fixing 1st bug in #16163

EDIT: fixing 2nd bug in #16165

timotheecour added a commit to timotheecour/Nim that referenced this issue Nov 28, 2020
@timotheecour
fix nim-lang#14242 testament r tests/js/foo now works; testament no…
7b47542 
…w honors --targets
@timotheecour timotheecour mentioned this issue Nov 28, 2020
Merged
timotheecour added a commit to timotheecour/Nim that referenced this issue Nov 28, 2020
@timotheecour
fix nim-lang#14242 testament r tests/js/foo now works; testament no…
fb406bd 
…w honors --targets
Araq pushed a commit that referenced this issue Nov 28, 2020
@timotheecour
fix #14242 testament r tests/js/foo now works; testament now honors…
1d786c0 
… --targets (#16163)

* fix #14242 `testament r tests/js/foo` now works; testament now honors --targets

* fix shouldfail
mildred pushed a commit to mildred/Nim that referenced this issue Jan 11, 2021
@timotheecour @mildred
fix nim-lang#14242 testament r tests/js/foo now works; testament no…
f0ef923 
…w honors --targets (nim-lang#16163)

* fix nim-lang#14242 `testament r tests/js/foo` now works; testament now honors --targets

* fix shouldfail
ardek66 pushed a commit to ardek66/Nim that referenced this issue Mar 26, 2021
@timotheecour @ardek66
fix nim-lang#14242 testament r tests/js/foo now works; testament no…
dc77f07 
…w honors --targets (nim-lang#16163)

* fix nim-lang#14242 `testament r tests/js/foo` now works; testament now honors --targets

* fix shouldfail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Medium Priority Test Suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #14242 testament r tests/js/foo now works; testament now honors --targets timotheecour/Nim
1 participant
@timotheecour