fix #14242 testament r tests/js/foo now works; testament now honors --targets
#16163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
commented
Nov 28, 2020
…w honors --targets
timotheecour
force-pushed
the
pr_testament_targets_r
branch
from
7b47542 to
fb406bd
Compare
Araq
reviewed
Nov 28, 2020
Araq
reviewed
Nov 28, 2020
| if not targetsSet: | ||
| let target = if cat.string.normalize == "js": targetJS else: targetC | ||
| targets = {target} | ||
| doAssert fileExists(test), test & " test does not exist" |
There was a problem hiding this comment.
This is input validaton, not an assertion.
There was a problem hiding this comment.
I agree but the doAssert is pre-existing, look at the diff.
we can discuss how to properly fix this in subsequent PR (quit is not the answer as it doesn't play well with library integration among other issues; enforce is the most natural fit but enforce PR #15606 is still open)
There was a problem hiding this comment.
quit is an answer until testament exposes an API. And only then we can add a callback for error handling or use a raise statement etc.
ringabout
reviewed
Nov 28, 2020
Totally agree with that, merged it. |
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
…w honors --targets (nim-lang#16163) * fix nim-lang#14242 `testament r tests/js/foo` now works; testament now honors --targets * fix shouldfail
This was referenced Jan 20, 2021
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
…w honors --targets (nim-lang#16163) * fix nim-lang#14242 `testament r tests/js/foo` now works; testament now honors --targets * fix shouldfail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #14242