fix testament regression: installed testament works again with testament r path #16767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2021
Araq
reviewed
Jan 20, 2021
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
…ent r path (nim-lang#16767) * fix testament regression: installed testament works again with testament r path * fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testament r tests/js/foonow works; testament now honors --targets #16163 (comment)to mimic installing testament and reproduce the bug that gets fixed here, do as follows:
nim c -o:/tmp/testament2 testament/testament.nim
move . to somewhere else to make sure the source files can't be read anymore
then:
mkdir -p tests/somedir
echo "doAssert 1 == 1" > tests/somedir/texample.nim
now these work:
/tmp/testament2 r tests/somedir/texample.nim
/tmp/testament2 r $PWD/tests/somedir/texample.nim
/tmp/testament2 r /patho/tests/somedir2/texample2.nim # can use external tests not relative to PWD
this doesn't work, because we can't get the category:
/tmp/testament2 r tests/texample.nim
(pre-existing issue IIRC, this could be relaxed in future work, by making
.a special category of its own for eg)