Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js should ignore threads:on #17267

Closed
ringabout opened this issue Mar 5, 2021 · 1 comment · Fixed by #17273
Closed

js should ignore threads:on #17267

ringabout opened this issue Mar 5, 2021 · 1 comment · Fixed by #17273
Labels
Easy Javascript

Comments

@ringabout
Copy link
Member 

echo "Hello"

nim js -r --threads:on app.nim

Error: 'getCurrentException' is not GC-safe as it accesses 'lastJSError' which is a global using GC'ed memory

Nim v1.4.2
Nim devel
@timotheecour timotheecour mentioned this issue Mar 6, 2021
Open
@timotheecour
Copy link
Member

ok.

ringabout added a commit to ringabout/Nim that referenced this issue Mar 6, 2021
@ringabout
fix nim-lang#17267
34e5ace
@ringabout ringabout mentioned this issue Mar 6, 2021
Merged
Araq pushed a commit that referenced this issue Mar 7, 2021
@ringabout
fix #17267 (#17273)
d1e0932 
* remove unnecessary when statement

* remove outdated codes

* reuse jsffi

* move js json coverage

* fix #17267

* address comments

* Update compiler/main.nim

* Update tests/threads/tjsthreads.nim
ringabout added a commit to ringabout/Nim that referenced this issue Mar 22, 2021
@ringabout
fix nim-lang#17267 (nim-lang#17273)
7185eea 
* remove unnecessary when statement

* remove outdated codes

* reuse jsffi

* move js json coverage

* fix nim-lang#17267

* address comments

* Update compiler/main.nim

* Update tests/threads/tjsthreads.nim
ardek66 pushed a commit to ardek66/Nim that referenced this issue Mar 26, 2021
@ringabout @ardek66
fix nim-lang#17267 (nim-lang#17273)
3766b47 
* remove unnecessary when statement

* remove outdated codes

* reuse jsffi

* move js json coverage

* fix nim-lang#17267

* address comments

* Update compiler/main.nim

* Update tests/threads/tjsthreads.nim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #17267 ringabout/Nim
2 participants
@timotheecour @ringabout