Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #17267 #17273

Merged
merged 13 commits into from
Mar 7, 2021
Merged

fix #17267 #17273

merged 13 commits into from
Mar 7, 2021

Conversation

ringabout
Copy link
Member

fix #17267

timotheecour
timotheecour reviewed Mar 6, 2021
View reviewed changes
compiler/main.nim Outdated Show resolved Hide resolved
ringabout
ringabout commented Mar 6, 2021
View reviewed changes
compiler/main.nim Outdated Show resolved Hide resolved
@Araq Araq merged commit d1e0932 into nim-lang:devel Mar 7, 2021
ringabout added a commit to ringabout/Nim that referenced this pull request Mar 22, 2021
@ringabout
fix nim-lang#17267 (nim-lang#17273)
7185eea 
* remove unnecessary when statement

* remove outdated codes

* reuse jsffi

* move js json coverage

* fix nim-lang#17267

* address comments

* Update compiler/main.nim

* Update tests/threads/tjsthreads.nim
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
@ringabout @ardek66
fix nim-lang#17267 (nim-lang#17273)
3766b47 
* remove unnecessary when statement

* remove outdated codes

* reuse jsffi

* move js json coverage

* fix nim-lang#17267

* address comments

* Update compiler/main.nim

* Update tests/threads/tjsthreads.nim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheecour timotheecour timotheecour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

js should ignore threads:on
3 participants
@ringabout @timotheecour @Araq