Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strutils:formatSize() is broken in JS mode #8231

Closed
genotrance opened this issue Jul 7, 2018 · 2 comments
Closed

strutils:formatSize() is broken in JS mode #8231

genotrance opened this issue Jul 7, 2018 · 2 comments
Labels
Javascript Standard Library

Comments

@genotrance
Copy link
Contributor 

import strutils

echo formatSize(2462056448, '.', bpIEC, false)

Echos 2.293GiB for C/C++ mode but 37568YiB for JS mode. Fails test case in strutils.nim but isn't getting caught since testament doesn't actually run the test, just compiles due to separate bug.
This was referenced Jul 7, 2018
Merged
Closed
@ghost
Copy link

ghost commented Jan 23, 2020 •
edited by ghost
Loading

I've investigated a bit, and it seems to be like that because bitwise operators in JS are 32-bit, so 1 << 40 gives 256 and not 1099511627776
A possible fix might be to make custom JS functions for bitwise operations so they'll work on both 32-bit and 64-bit

bung87 added a commit to bung87/Nim that referenced this issue Jul 25, 2020
@bung87
avoid nim-lang#8231, bitwise move to mul,div
9fc7f84
@bung87 bung87 mentioned this issue Jul 28, 2020
Merged
bung87 added a commit to bung87/Nim that referenced this issue Aug 24, 2020
@bung87
add test for nim-lang#8231
fbc6a1d
Araq pushed a commit that referenced this issue Aug 25, 2020
@bung87
avoid #8231, bitwise move to mul,div (#15070)
7cee63b 
* avoid #8231, bitwise move to mul,div

* add test for #8231

* fix bitwise move when div result is float

* bitwise move depends on typ.size
@mratsim
Copy link
Collaborator

mratsim commented Aug 26, 2020

Fixed by #15070

@mratsim mratsim closed this as completed Aug 26, 2020
mildred pushed a commit to mildred/Nim that referenced this issue Jan 11, 2021
@bung87 @mildred
avoid nim-lang#8231, bitwise move to mul,div (nim-lang#15070)
63657ea 
* avoid nim-lang#8231, bitwise move to mul,div

* add test for nim-lang#8231

* fix bitwise move when div result is float

* bitwise move depends on typ.size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Javascript Standard Library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@genotrance @andreaferretti @mratsim