avoid #8231, bitwise move to mul,div #15070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you write a test for #8231? |
narimiran
reviewed
Aug 24, 2020
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
* avoid nim-lang#8231, bitwise move to mul,div * add test for nim-lang#8231 * fix bitwise move when div result is float * bitwise move depends on typ.size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoiding #8231
"bitwise operators in JS are 32-bit" as @Yardanico said
the PNode .intVal store as BigestInt which currently is int64 which I dont want touch it, instead changing bitwise move operation to mul and div.