Undefine paramCount & paramStr in nimscript.nim for *.nims
#12860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's better to remove them from |
nc-x
changed the title
paramCount & paramStr in os.nim for *.nimsparamCount & paramStr in nimscript.nim for *.nims
|
Excellent work, now the only missing part is a changelog entry and backwards compat. |
metagn
reviewed
Apr 27, 2020
|
This is now blocked on nim-lang/nimble#797 Line 13 in 664cb2c and this PR should (hopefully) be green. |
|
Ready to be merged. |
|
Isn't this a breaking change? |
|
Yeah, it is, I noticed when installing |
|
@Yardanico |
Araq
added a commit
that referenced
this pull request
Apr 30, 2020
EchoPouet
pushed a commit
to EchoPouet/Nim
that referenced
this pull request
Jun 13, 2020
…ang#12860) * Remove `paramStr` and `paramCount` from implicitly imported nimscript.nim * Update changelog.md * Update stable nimble commit hash Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
EchoPouet
pushed a commit
to EchoPouet/Nim
that referenced
this pull request
Jun 13, 2020
timotheecour
added a commit
to timotheecour/Nim
that referenced
this pull request
Jun 14, 2020
This reverts commit 3d2459b.
timotheecour
added a commit
to timotheecour/Nim
that referenced
this pull request
Jun 14, 2020
nim-lang#12860)" This reverts commit d38853c.
timotheecour
added a commit
to timotheecour/Nim
that referenced
this pull request
Jun 15, 2020
This reverts commit 3d2459b.
timotheecour
added a commit
to timotheecour/Nim
that referenced
this pull request
Jun 15, 2020
nim-lang#12860)" This reverts commit d38853c.
Araq
pushed a commit
that referenced
this pull request
Jun 16, 2020
* fix #14142: no more clash with: import os + use of existsDir/dirExists/existsFile/fileExists/findExe in config.nims * remove a comment * Revert "fixes the regression #12860 caused; hotfix" This reverts commit 3d2459b. * Revert "Undefine `paramCount` & `paramStr` in nimscript.nim for *.nims (#12860)" This reverts commit d38853c. * noNimScript => noWeirdTarget + noNimJs
This was referenced Jul 10, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(and fix error message on js target)
Closes #12835