Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #14179, fix #14142, make CI 1.4x faster (2x faster locally) #14658

Merged
merged 7 commits into from
Jun 16, 2020

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Jun 14, 2020

see #14179 (comment) for the full context

CI timings on CI machines

before PR => after PR
Linux_amd64 31m => 21m
Linux_i386 32m => 18m
OSX_amd64 17m => 13m
OSX_amd64_cpp 18m => 13m
Windows_amd64 38m => 33m

CI timings locally on OSX

via XDG_CONFIG_HOME= nim c -r testament/testament all
494s => 253s
(didn't try ./koch runCI locally in this experiment)

@timotheecour timotheecour changed the title fix #14179 fix #14142 make CI faster fix #14179, fix #14142, make CI faster Jun 14, 2020
@timotheecour timotheecour changed the title fix #14179, fix #14142, make CI faster fix #14179, fix #14142, make CI 1.4x faster (2x faster locally) Jun 14, 2020
@timotheecour timotheecour marked this pull request as ready for review June 14, 2020 12:20
compiler/condsyms.nim Outdated Show resolved Hide resolved
lib/pure/os.nim Show resolved Hide resolved
@timotheecour timotheecour force-pushed the pr_fix_14179_nim_dump_slow2 branch from 899fa9c to 5ea332b Compare June 15, 2020 22:06
@timotheecour
Copy link
Member Author

timotheecour commented Jun 15, 2020

@Araq PTAL, the last commit should address all your concerns (and also provide less misleading error msgs with nim js).

@Araq
Copy link
Member

Araq commented Jun 16, 2020

Thank you, superb work now.

@Araq Araq merged commit 45cac4a into nim-lang:devel Jun 16, 2020
@timotheecour timotheecour deleted the pr_fix_14179_nim_dump_slow2 branch June 16, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants