Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14715 - detect tool fails on FreeBSD #14716

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Conversation

euantorano
Copy link
Contributor

Fixes #14715

FreeBSD also requires linking the math library (see fenv). It seems NetBSD does too, though I haven't tested there.

Tested locally on FreeBSD and it appears to work - I now get a freebsd_amd64_consts.nim being generated at least.

@lbartoletti
Copy link
Contributor

lbartoletti commented Jun 18, 2020

it still failed for me with nim 1.2.0 (from pkg) and devel. gcc not found

@euantorano
Copy link
Contributor Author

euantorano commented Jun 18, 2020 via email

@euantorano
Copy link
Contributor Author

CI failure seems unrelated.

I can't seem to replicate your problem @lbartoletti. Can you please explain the steps you took? My steps are as follows:

> git clone https://github.com/nim-lang/Nim.git
> cd Nim
> ./build_all.sh
> ./bin/nim c -r tools/detect/detect.nim

@Araq Araq merged commit a3ae52d into nim-lang:devel Jun 24, 2020
@lbartoletti
Copy link
Contributor

@euantorano Yes, it's work. Sorry for the noise. I think there was a conflict with my installation. Dunno why I have to add a if at https://github.com/nim-lang/Nim/pull/14716/files#diff-d48a4f09dba4c4b83ca9f8cf908e2ca5R101

@euantorano euantorano deleted the patch-1 branch June 24, 2020 16:29
euantorano added a commit to euantorano/Nim that referenced this pull request Jun 24, 2020
Araq pushed a commit that referenced this pull request Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect tool fails on FreeBSD
3 participants