Patch #14716 - add missing when

[euantorano]

Patch for #14716 - seems a when was lost in the PR and was missed before merging.

[timotheecour]

@euantorano this means CI doesn't catch this and should be fixed, at very least by trying to compile detect.nim; do you mind adding some test?

[euantorano]

I’m not sure if any of the tools are built or ran under CI at all at the moment. It would be easy enough to add another CI step to try build and run them and just ensure they run successfully (e.g. have a 0 exit code) which is probably enough?

…

On Wed, 24 Jun 2020, at 23:03, Timothee Cour wrote: @euantorano <https://github.com/euantorano> this means CI doesn't catch this and should be fixed, at very least by trying to compile detect.nim; do you mind adding some test? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14792 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFW24OO7CULPHQVFF5H633RYJZ3XANCNFSM4OG2SMSA>.

[timotheecour]

any of the steps below is better than nothing:

• step 0: ensure tools compiles
• step 1: ensure they run
• step 2: ensure they give correct results

so long it doesn't add significant time to CI, there's no drawbacks in doing this
but please don't add a new CI pipeline, just add code under koch.runCI

[euantorano]

I'll try find a chance to look into it. Checking for correct results may be difficult due to the results being platform dependent. I'll open an issue.