-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #16384 and #17144 #17126
fix #16384 and #17144 #17126
Conversation
Why backport? This is not a regression and risky in itself. |
the codes from #16384 works for Nim 1.4.0 but failed at Nim 1.4.2. This PR fix the issue? |
LGTM after removing the also note for other reviewers that to view the diff, it's best to do it locally after diffing against a file where you indent the whole test inside a
|
I'd be fine with backporting this in its current state, but can be decided later. |
fix #16384
fix #17144