Skip to content

fix #16384 and #17144 #17126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 3, 2021
Merged

fix #16384 and #17144 #17126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a0c6393
fix js unsigned integer
ringabout Feb 18, 2021
9a40fbf
better
ringabout Feb 18, 2021
9319749
Merge remote-tracking branch 'upstream/devel' into a90
ringabout Feb 19, 2021
5f5c862
Use `std` prefix for standard library modules
ringabout Feb 19, 2021
67e5353
Merge remote-tracking branch 'upstream/devel' into a94
ringabout Feb 20, 2021
3f846a2
fix #16384
ringabout Feb 21, 2021
841f9ca
only check oince
ringabout Feb 21, 2021
6a12e12
Merge remote-tracking branch 'upstream/devel' into a97
ringabout Feb 21, 2021
28c7dfa
Update tests/stdlib/tlists.nim
ringabout Feb 22, 2021
b81f027
fix
ringabout Mar 3, 2021
e59e96f
remove fixme
ringabout Mar 3, 2021
fc83fff
Update compiler/vm.nim
ringabout Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion compiler/vm.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,7 +1019,8 @@ proc rawExecute(c: PCtx, start: int, tos: PStackFrame): TFullReg =
let nc = regs[rc].node
if nb.kind != nc.kind: discard
elif (nb == nc) or (nb.kind == nkNilLit): ret = true # intentional
elif sameConstant(nb, nc): ret = true
elif (nb.kind in {nkSym, nkTupleConstr, nkClosure} and nb.typ.kind == tyProc) and sameConstant(nb, nc):
ret = true
# this also takes care of procvar's, represented as nkTupleConstr, e.g. (nil, nil)
elif nb.kind == nkIntLit and nc.kind == nkIntLit and nb.intVal == nc.intVal: # TODO: nkPtrLit
let tb = nb.getTyp
Expand Down
Loading