move assertions out of system #19599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringabout
commented
Mar 9, 2022
Comment on lines
+1833
to
+1837
| when not defined(nimPreviewSlimSystem): | ||
| {.deprecated: """assertions is about to move out of system; use `-d:nimPreviewSlimSystem` and | ||
| import `std/assertions`.""".} | ||
| import std/assertions | ||
| export assertions |
There was a problem hiding this comment.
This is a bad idea, users have no control over system.nim. Instead remove the import/export of assertions and patch the tests. Important packages can be compiled via --useVersion:1.6 or similar.
There was a problem hiding this comment.
Ok, here is the first step: #19601 (support useVersion:1.6)
There was a problem hiding this comment.
Is something like this okay?
|
Except the two files I mentioned above, others changes are about import std/assertions(syncio) under I use command |
This was referenced Mar 9, 2022
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref nim-lang/RFCs#437