move assertions out of system: alternative way

[ringabout]

[ringabout]

Hello @Araq

Is something below fine or any advice?

• compiler/ uses import std/assserts direct
• lib/ uses since (1, 7): import std/assserts for --useVersion:1.6
• tests/ uses import std/assserts direct
• patch nimble and c2nim using --useVersion:1.6
• important packages use --useVersion:1.6
• runnableExamples uses import std/assserts direct
• patch docs and code-blocks

ref #19599 (comment)

[Araq]

Solid solution. I worry a bit about point

runnableExamples or code-examples uses import std/assserts direct

But I have no better solution either, so it's probably fine.

[ringabout]

I see, thanks

[ringabout]

It seems to need to patch nimble and c2nim using --useVersion:1.6 in this PR.

[ringabout]

This pr will focus on simply addition of import std/assertions. Other changes will move into separate PRs.

[ringabout]

• make --useVersion:1.6 work for .nimble file of important packages or something

some nimble files of important packages contain assert/doAssert

[ringabout]

• it breaks the runnableExamples of important packages

I'm considering importing std/assertions automatically for runnableExamples for this PR transiently.

• it breaks the building of important packages

[ringabout]

import std/assertions

gives D:\a\1\s\lib\pure\collections\sequtils.nim(585, 12) Error: undeclared identifier: 'std' strangely.

[ringabout]

The tests seem fines (CI failures are unrelated). After the final cleanup, I will split the key changes into separate PRs.