Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trivial] tester.nim add more diagnostics #8631

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Aug 14, 2018

  • getCurrentExceptionMsg() was added in this block:
except IOError:
  given.err = reCodeNotFound

to provide useful diagnostics when IOError occur; otherwise looking at logs is not helpful:

example from a failed travis job: https://travis-ci.org/nim-lang/Nim/jobs/416117242

with this PR we get the useful line "cannot open: nimcache/tests/pragmas/tnoreturn.nim_0d61f8370cad1d412f80b84d143e1257/.tests.pragmas.tnoreturn.c" :

PASS: tcopying.nim JS -d:nodejs -d:release                         (1.76057816 secs)
cannot open: nimcache/tests/pragmas/tnoreturn.nim_0d61f8370cad1d412f80b84d143e1257/.tests.pragmas.tnoreturn.c
FAIL: tnoreturn.nim C
Test "tests/pragmas/tnoreturn.nim" in category "pragmas"
Failure: reCodeNotFound
Expected:
Gotten:

without this PR, all we get is the enigmatic "Failure: reCodeNotFound"

  • " failed: ", failed was added in test result output, because it's easier for readers to see how many test failed without having to do some math

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants